ref(grouping): Expand datetime message parameterization#109706
Merged
lobsterkatie merged 2 commits intomasterfrom Mar 2, 2026
Merged
ref(grouping): Expand datetime message parameterization#109706lobsterkatie merged 2 commits intomasterfrom
lobsterkatie merged 2 commits intomasterfrom
Conversation
wedamija
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors our datetime parameterization regexes to combine one set of the "old, potentially-removable" patterns (which has been spotted in the wild, so no, we can't remove it) with the current dash-optional pattern, and then expands the resulting pattern set so the colons in the time are optional as well. It then splits the set in two for greater readability. The resulting pattern set now handles the following:
Date with or without dashes and time with or without colons
Date and time separated either by a space or by
TDecimal seconds, integer seconds, or no seconds
Timezone information given as offset, as
Z(UTC), or not given at all