ref(grouping): Expand hex parameterization to include numbers with 9-15 digits#109751
Merged
lobsterkatie merged 3 commits intomasterfrom Mar 4, 2026
Merged
Conversation
b5511dd to
94030cd
Compare
wedamija
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing some orgs which are sending message events which include hex strings of lengths (10 characters, 12 characters, etc.) that we don't currently match. This PR therefore expands our hex parameterization to include all strings which are between 8 and 128 characters (so no more gap from 9 and 15). This has the added advantage of allowing us to simplify our regex a bit.