fix(dashboards): Respect current time series interval in Widget Viewer#109766
Merged
fix(dashboards): Respect current time series interval in Widget Viewer#109766
Conversation
The Widget Viewer Modal was not receiving the dashboard's interval selection, causing charts to revert to the default interval when opened in full screen. Thread widgetInterval through WidgetCardChartContainer and the modal's query components so the user-selected interval is respected. Refs DAIN-1257 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
gggritso
changed the title
gggritso
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the dashboard's user-selected interval to the Widget Viewer Modal so
that opening a widget in full screen preserves the chosen interval instead
of reverting to the default. This is especially important when we remove
our custom data cache. If the interval changes, TanStack will issue another
network request to fetch the data!
The interval selection feature lets users pick a chart interval (e.g. 1m,
15m) for all time series widgets on a dashboard. This value was already
threaded through the main dashboard widget rendering path, but the Widget
Viewer Modal never received it. When a widget was opened in full screen,
its chart would re-fetch data without the interval override, causing a
jarring change in granularity.
Three changes:
widgetIntervaltoWidgetViewerModalOptionsand pass it to thechart container and all table query components inside the modal
widgetIntervaltoWidgetCardChartContainerprops so it canforward the value to
WidgetCardDataLoaderthis.props.widgetIntervalwhen opening the modal inDashboardDetail.checkIfShouldMountWidgetViewerModalRefs DAIN-1257