fix(dashboards): Preserve polarity when clearing threshold values#109872
Merged
DominikB2014 merged 1 commit intomasterfrom Mar 4, 2026
Conversation
When all threshold max values are cleared, the preferredPolarity was lost because the entire thresholds config was set to null. This caused the polarity to flip back to the default "lower is better" when the user re-entered threshold values. Fixes DAIN-1275 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Mar 4, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1275-clearing-dashboard-thresholds-flips-higherlower-is-better
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all threshold max values are cleared in the widget builder, the entire
thresholdsconfig was set tonull, which lost thepreferredPolaritysetting. When the user re-entered threshold values, the polarity defaulted
back to "lower is better" (
-), even if they had previously selected"higher is better" (
+).Now when clearing all max values, the
preferredPolarityis preserved inthe thresholds config so it persists across clearing and re-entering values.
Fixes DAIN-1275