Conversation
…rements Previously, measurement fields like `p75(measurements.lcp)` had their labels replaced with just the uppercase slug (e.g., `LCP`), which stripped the percentile indicator. This made it impossible to distinguish between e.g. p50 and p75 of the same measurement. Remove the special-case measurement formatting so the full expression is shown in the legend. Refs DAIN-1237 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
gggritso
changed the title
edwardgou-sentry
approved these changes
Mar 4, 2026
gggritso
deleted the
georgegritsouk/dain-1237-dashboards-percentile-indicator-missing-when-selecting
branch
JonasBa
pushed a commit
that referenced
this pull request
Mar 5, 2026
…rements (#109901) Remove special-case measurement formatting that replaced full aggregate expressions like `p75(measurements.lcp)` with just `LCP` in chart legends. Previously, if multiple aggregates of a Web Vitals like `p75(measurements.lcp)` and `p50(measurements.lcp)` were on the same chart, they would display as `LCP` in the legend, making it impossible to distinguish which percentile was being shown. Now the full expression is preserved. **Before:** <img width="469" height="272" alt="Screenshot 2026-03-04 at 3 13 07 PM" src="https://github.com/user-attachments/assets/8633cc43-7e6a-452f-bf1e-da424c78efa2" /> **After:** <img width="463" height="272" alt="Screenshot 2026-03-04 at 3 14 47 PM" src="https://github.com/user-attachments/assets/90e481ca-aa2b-408d-95bf-d9f6dc1a8f37" /> Fixes DAIN-1237 Co-authored-by: Claude <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove special-case measurement formatting that replaced full aggregate expressions like
p75(measurements.lcp)with justLCPin chart legends.Previously, if multiple aggregates of a Web Vitals like
p75(measurements.lcp)andp50(measurements.lcp)were on the same chart, they would display asLCPin the legend, making it impossible to distinguish which percentile was being shown. Now the full expression is preserved.Before:
After:
Fixes DAIN-1237