fix(logs): simplify CellAction rendering to only be used if needed#109946
Merged
JoshuaKGoldberg merged 2 commits intomasterfrom Mar 6, 2026
Merged
fix(logs): simplify CellAction rendering to only be used if needed#109946JoshuaKGoldberg merged 2 commits intomasterfrom
JoshuaKGoldberg merged 2 commits intomasterfrom
Conversation
k-fish
approved these changes
Mar 5, 2026
JoshuaKGoldberg
force-pushed
the
logs-table-streamlined-cell-actions
branch
from
8f72979 to
a5a137c
Compare
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
commented
Mar 6, 2026
| // Expand the row to show the attributes | ||
| const logTableRow = await screen.findByTestId('log-table-row'); | ||
| expect(logTableRow).toBeInTheDocument(); | ||
| await userEvent.hover(logTableRow); |
Member
Author
There was a problem hiding this comment.
Now that deferred rendering is always enabled, the row needs to be hovered to enable shouldRenderActions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies two streamlinings:
canDeferRenderElementsprop, so deferred rendering again always becomes available...CellActionswhen there won't be any actions anyway, such as in (static?) embedded tablesPart of LOGS-589.