fix(vercel): Adds signature check to vercel delete endpoint#109974
Merged
Christinarlong merged 4 commits intomasterfrom Mar 10, 2026
Merged
fix(vercel): Adds signature check to vercel delete endpoint#109974Christinarlong merged 4 commits intomasterfrom
Christinarlong merged 4 commits intomasterfrom
Conversation
Contributor
michelletran-sentry
left a comment
There was a problem hiding this comment.
Since all the endpoints in VercelWebhookEndpoint require signature validation, thoughts on creating a custom authentication class for this REST resource?
Maybe something like:
class VercelSignatureAuthentication(authentication.BaseAuthentication):
def authenticate(self, request: Request) -> tuple[Any, Any]:
if not verify_signature(request):
raise AuthenticationFailed("Invalid signature.")
return None
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we're not doing a signature check on requests on the delete endpoint for vercel
Fixes VULN-1153