Skip to content

ref(discover): replace browserHistory with useNavigate in landing #110010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpurkhiser merged 2 commits into from
Mar 6, 2026
Merged

ref(discover): replace browserHistory with useNavigate in landing #110010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8830e32
ref(discover): replace browserHistory with useNavigate in landing
evanpurkhiser Mar 5, 2026
2d5d022
Merge branch 'master' into evanpurkhiser/ref-discover-replace-browser…
evanpurkhiser Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions static/app/views/discover/landing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ import type {SelectValue} from 'sentry/types/core';
import type {NewQuery, SavedQuery} from 'sentry/types/organization';
import {trackAnalytics} from 'sentry/utils/analytics';
import getApiUrl from 'sentry/utils/api/getApiUrl';
import {browserHistory} from 'sentry/utils/browserHistory';
import EventView from 'sentry/utils/discover/eventView';
import {getDiscoverLandingUrl} from 'sentry/utils/discover/urls';
import {useApiQuery} from 'sentry/utils/queryClient';
import {decodeScalar} from 'sentry/utils/queryString';
import {useLocalStorageState} from 'sentry/utils/useLocalStorageState';
import {useLocation} from 'sentry/utils/useLocation';
import {useNavigate} from 'sentry/utils/useNavigate';
import useOrganization from 'sentry/utils/useOrganization';
import {makeDiscoverPathname} from 'sentry/views/discover/pathnames';
import {getSavedQueryWithDataset} from 'sentry/views/discover/savedQuery/utils';
Expand Down Expand Up @@ -131,6 +131,7 @@ const useDiscoverLandingQuery = (renderPrebuilt: boolean) => {
const RENDER_PREBUILT_KEY = 'discover-render-prebuilt';

function DiscoverLanding() {
const navigate = useNavigate();
const organization = useOrganization();
const location = useLocation();
const activeSort = useActiveSort();
Expand Down Expand Up @@ -158,7 +159,7 @@ function DiscoverLanding() {

const handleSortChange = (value: string) => {
trackAnalytics('discover_v2.change_sort', {organization, sort: value});
browserHistory.push({
navigate({
pathname: location.pathname,
query: {
...location.query,
Expand All @@ -169,7 +170,7 @@ function DiscoverLanding() {
};

const handleSearchQuery = (searchQuery: string) => {
browserHistory.push({
navigate({
pathname: location.pathname,
query: {
...location.query,
Expand Down
Loading