Skip to content

ref(performance): replace browserHistory with useNavigate in tagExplorer #110012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpurkhiser merged 1 commit into from
Mar 6, 2026
Merged

ref(performance): replace browserHistory with useNavigate in tagExplorer #110012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions static/app/views/performance/transactionSummary/transactionOverview/tagExplorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {space} from 'sentry/styles/space';
import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {trackAnalytics} from 'sentry/utils/analytics';
import {browserHistory} from 'sentry/utils/browserHistory';
import type EventView from 'sentry/utils/discover/eventView';
import {isFieldSortable} from 'sentry/utils/discover/eventView';
import {fieldAlignment} from 'sentry/utils/discover/fields';
Expand All @@ -29,6 +28,7 @@ import type {
} from 'sentry/utils/performance/segmentExplorer/segmentExplorerQuery';
import SegmentExplorerQuery from 'sentry/utils/performance/segmentExplorer/segmentExplorerQuery';
import {decodeScalar, decodeSorts} from 'sentry/utils/queryString';
import {useNavigate} from 'sentry/utils/useNavigate';
import CellAction, {Actions, updateQuery} from 'sentry/views/discover/table/cellAction';
import type {TableColumn} from 'sentry/views/discover/table/types';
import {
Expand Down Expand Up @@ -195,6 +195,7 @@ export function TagExplorer(props: Props) {
domainViewFilters,
} = props;

const navigate = useNavigate();
const [widths, setWidths] = useState<number[]>([]);

const handleResizeColumn = useCallback(
Expand Down Expand Up @@ -290,7 +291,7 @@ export function TagExplorer(props: Props) {

updateQuery(searchConditions, action, {...column, name: actionRow.id}, tagValue);

browserHistory.push({
navigate({
pathname: location.pathname,
query: {
...location.query,
Expand Down Expand Up @@ -458,13 +459,14 @@ type HeaderProps = {

function TagsHeader(props: HeaderProps) {
const domainViewFilters = useDomainViewFilters();
const navigate = useNavigate();
const {pageLinks, organization, location, transactionName} = props;

const handleCursor: CursorHandler = (cursor, pathname, query) => {
trackAnalytics('performance_views.summary.tag_explorer.change_page', {
organization,
});
browserHistory.push({
navigate({
pathname,
query: {...query, [TAGS_CURSOR_NAME]: cursor},
});
Expand Down
Loading