ref(ci): use shared setup-node-pnpm action in acceptance workflow#110022
Merged
hubertdeng123 merged 1 commit intomasterfrom Mar 6, 2026
Merged
ref(ci): use shared setup-node-pnpm action in acceptance workflow#110022hubertdeng123 merged 1 commit intomasterfrom
hubertdeng123 merged 1 commit intomasterfrom
Conversation
The acceptance workflow was manually duplicating the node/pnpm setup steps (actions/setup-node, pnpm/action-setup, node_modules cache, install) already encapsulated in the .github/actions/setup-node-pnpm composite action. Replace the 4 duplicated steps with the shared action to reduce duplication and improve maintainability.
joshuarli
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acceptance.ymlworkflow was manually duplicating 4 steps already abstracted into.github/actions/setup-node-pnpm:actions/setup-node,pnpm/action-setup, anode_modulescache step, and a conditional install step.uses: ./.github/actions/setup-node-pnpmcall, matching the pattern used infrontend.yml,pre-commit.yml, andbackend.yml(api-docs job).Test plan
acceptanceCI job passes after this changenode_modulescache hit/miss behavior is unchanged (same cache key:pnpm-lock.yaml,api-docs/pnpm-lock.yaml,.node-version)