ref(replays): Clean up granular-replay-permissions feature flag (backend)#110036
Merged
priscilawebdev merged 2 commits intomasterfrom Mar 11, 2026
Merged
Conversation
Remove the `organizations:granular-replay-permissions` feature flag so the granular replay permissions feature is always available. The org option `sentry:granular-replay-permissions` still controls whether the feature is active per-organization. Refs TET-2017 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
shellmayr
reviewed
Mar 10, 2026
| manager.add("organizations:gen-ai-consent", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | ||
| # Enable granular permissions for replay features | ||
| manager.add("organizations:granular-replay-permissions", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | ||
|
|
Member
There was a problem hiding this comment.
Feature flag registration should be removed last (see docs) - this should be done at the very end I think
shellmayr
approved these changes
Mar 10, 2026
Member
shellmayr
left a comment
shellmayr
left a comment
There was a problem hiding this comment.
Looks good - but I think we should remove the frontend portion of this first - the frontend retrieves the info about the feature flag from the API, so if we remove it in the API, the feature will stop working until the frontend is merged, and we shouldn't let that happen.
Restoring the flag registration to be removed in a follow-up PR per flagpole removal docs. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
priscilawebdev
deleted the
ref/clean-up-granular-replay-permissions-flag
branch
priscilawebdev
added a commit
that referenced
this pull request
Mar 11, 2026
…110397) Removes the `organizations:granular-replay-permissions` feature flag registration from `temporary.py`. This is the final cleanup step per the [flagpole removal docs](https://develop.sentry.dev/backend/application-domains/feature-flags/flagpole/#removing-flagpole-features), to be merged after #110036.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
organizations:granular-replay-permissionsfeature flag so granular replay permissions are always available. The org optionsentry:granular-replay-permissionsstill controls whether the feature is active per-organization.Changes:
temporary.pyfeatures.has()checks inpermissions.py,organization.pyserializer, andorganization_details.pyvalidationhasGranularReplayPermissionsandreplayAccessMembersbased on the org option (no longer gated behind the feature flag)@with_featuredecorators andself.feature()context managers for this flag from remaining testsRefs TET-2017