Merged
Conversation
JoshuaKGoldberg
approved these changes
Mar 6, 2026
|
|
||
| - The transformation alters control flow or runtime behavior | ||
| - Multiple valid fixes exist and the right choice requires human judgment | ||
| - The fix requires type information not available from the AST alone |
Member
There was a problem hiding this comment.
Ooh, interesting! How come?
Member
Author
There was a problem hiding this comment.
Nice flag, that requires a bit more nuance! We can leverage type-aware rules, but we don't run them in precommit for performance reasons.
.agents/skills/lint-new/SKILL.md
Outdated
| | `decomposeValue` | `src/ast/extractor/value-decomposer.ts` | Breaking complex expressions into all possible values | | ||
| | Theme tracker | `src/ast/extractor/theme.ts` | Tracking `useTheme()` and callback theme bindings | | ||
|
|
||
| If another rule already detects the same pattern, extract the shared logic into `src/ast/utils/` and reuse it. |
Member
There was a problem hiding this comment.
[Praise] This section is great! +1
Member
Author
There was a problem hiding this comment.
After some testing, in practice this unfortunately didn't provide strong enough guidance to prevent duplicate patterns! I'm going to push an iteration with better guardrails.
|
|
||
| ## Coordinating Large Changes | ||
|
|
||
| - Split PRs to **~50 changed files** based on ownership rules in @.github/CODEOWNERS. |
Co-authored-by: Josh Goldberg ✨ <github@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <github@joshuakgoldberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
/lint-newand/lint-fixskills./lint-newprovides guidance for creating a new custom ESLint rule in theeslintPluginScrapsdirectory, writing tests, and managing common patterns./lint-fixprovides guidance for fixing specific lint violations. Because of the size of our codebase, agents often begin fixes without realizing the scale demands an alternative strategy, so this rule bakes in some heuristics that guide agents towards manual, batched, or automated fixes.