feat(snapshots): Fix sidebar rendering for uploads with lots of images#110156
Merged
NicoHinderling merged 1 commit intomasterfrom Mar 6, 2026
Conversation
This was referenced Mar 6, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
rbro112
approved these changes
Mar 6, 2026
Base automatically changed from
03-04-feat_snapshots_add_d3-zoom_interactivity
to
master
March 6, 2026 21:19
NicoHinderling
force-pushed
the
03-06-feat_snapshots_fix_sidebar_rendering_for_uploads_with_lots_of_images
branch
from
70b3fed to
0161fd7
Compare
NicoHinderling
force-pushed
the
03-06-feat_snapshots_fix_sidebar_rendering_for_uploads_with_lots_of_images
branch
from
0161fd7 to
15b9517
Compare
NicoHinderling
deleted the
03-06-feat_snapshots_fix_sidebar_rendering_for_uploads_with_lots_of_images
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove pagination from the snapshot details API endpoint and simplify the frontend to load all images in a single request.
The snapshot sidebar previously used
useInfiniteApiQuerywith anIntersectionObserver-based infinite scroll to paginate through images 20 at a time. This caused layout instability — the sidebar's scrollbar would jump as new pages loaded, making it difficult to browse uploads with many images. Since snapshot metadata (image keys, display names, dimensions) is lightweight and the endpoint already loads the full manifest from object storage in one call, paginating the response added complexity without meaningful performance benefit.Changes:
self.paginate()with a directResponse(), removing theOffsetPaginatordependency. IncreasemaxPropertiesfrom 1,000 to 50,000 to support larger uploads.useInfiniteApiQuerytouseApiQuery, remove theIntersectionObserversentinel and loading spinner, and pass the total image count to the search placeholder ("Search 537 images...").