Skip to content

fix(aci): Add charts to contributing issues#110162

Merged
scttcper merged 2 commits intomasterfrom
scttcper/contributing-issues-chart
Mar 9, 2026
Merged

fix(aci): Add charts to contributing issues#110162
scttcper merged 2 commits intomasterfrom
scttcper/contributing-issues-chart

Conversation

@scttcper
Copy link
Member

@scttcper scttcper commented Mar 6, 2026

Activates the graph column for contributing issues https://sentry.sentry.io/issues/7096697783/

@scttcper scttcper requested a review from a team March 6, 2026 21:53
@scttcper scttcper requested a review from a team as a code owner March 6, 2026 21:53
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 6, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

queryParams={queryParams}
canSelectGroups={false}
withChart={false}
withChart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart stats period misaligned with query time range

Medium Severity

Enabling withChart without passing groupStatsPeriod: 'auto' in queryParams (or customStatsPeriod to GroupList) means the charts will always display a fixed 24-hour stats period, even though the issues are queried for the open period's custom start/end range. The comparable relatedIssues.tsx correctly passes both groupStatsPeriod: 'auto' and customStatsPeriod to align the chart data with the query time range. When the open period extends beyond 24 hours, the chart will show misleading, incomplete data.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scttcper this looks like it's right, we do want an auto stats period

@scttcper scttcper merged commit 114168c into master Mar 9, 2026
59 checks passed
@scttcper scttcper deleted the scttcper/contributing-issues-chart branch March 9, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants