Skip to content

fix(explorer): handle missing counts in get_filter_key_values and don't query both backends#110172

Merged
aliu39 merged 4 commits intomasterfrom
aliu/filterkv-merge-fix
Mar 9, 2026
Merged

fix(explorer): handle missing counts in get_filter_key_values and don't query both backends#110172
aliu39 merged 4 commits intomasterfrom
aliu/filterkv-merge-fix

Conversation

@aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 6, 2026

Fixes SENTRY-5KXR

The response type is TagValueSerializerResponse which appears to incorrectly have int count rather than int | None. Based on TagValue and TagValueSerializer, values and counts can be none. Updates the type and handle this edge case in our rpc by dropping them.

Also follows the pattern of skipping the feature flags query if we got results from tags, matching what we do for get_event_filter_key_values

@aliu39 aliu39 requested a review from a team as a code owner March 6, 2026 23:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 6, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@aliu39 aliu39 changed the title fix(explorer): handle missing counts in get_filter_key_values fix(explorer): handle missing counts in get_filter_key_values and don't query both backends Mar 9, 2026
@aliu39 aliu39 merged commit 73dd13f into master Mar 9, 2026
60 of 61 checks passed
@aliu39 aliu39 deleted the aliu/filterkv-merge-fix branch March 9, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants