chore(codeowners): Remove stale entries and add missing assignments#110176
Open
chore(codeowners): Remove stale entries and add missing assignments#110176
Conversation
Remove 10 entries for deleted files/dirs and update 11 entries for files/dirs that were moved. Removed (deleted from codebase): - /src/sentry/search/events/datasets/metrics_layer.py (removed in #108755) - /src/sentry/utils/relocation.py (removed in #101738) - requirements*.txt (removed in #97627, uv migration) - babel.config.* (removed in #93303, jest 30 migration) - jest-balance.json (never existed as tracked file) - /src/sentry/api/endpoints/user_social_identity* (removed in #77231) - /src/sentry/tasks/check_new_issue_threshold_met.py (removed in #97894) - /tests/sentry/tasks/test_backfill_seer_grouping_records.py (removed in #102364) - /tests/sentry/tasks/test_check_new_issue_threshold_met.py (removed in #97894) - /src/sentry/api/endpoints/check_am2_compatibility.py (removed in #104288) Updated (moved to new locations): - event_reprocessable.py → /src/sentry/issues/endpoints/ (#97900) - organization_event_details.py → /src/sentry/issues/endpoints/ (#97428) - /static/app/{components,views}/codecov/ → .../prevent/ (#97485) - organizationoption.py → models/options/organization_option.py (#31615) - projectoption.py → models/options/project_option.py (#31615) - useroption.py → users/models/user_option.py (#76231) - organization_projects_experiment.py → /src/sentry/core/endpoints/ (#97407) - release_threshold*.py → release_thresholds/ directory (#57085) - test_organization_projects_experiment.py → /tests/sentry/core/endpoints/ (#97407) - test_scim*.py → /tests/sentry/core/endpoints/scim/ (core migration)
github-actions
bot
added
the
Scope: Backend
Contributor
Backend Test FailuresFailures on
|
Assign ownership to 7 directories that had no CODEOWNERS coverage: - /src/sentry/rules/ → @getsentry/alerts-notifications (111 files) - /src/sentry/middleware/integrations/ → @getsentry/ecosystem (39 files) - /src/sentry/explore/ → @getsentry/explore (31 files) - /src/sentry/lang/java/ → @getsentry/ingest (16 files) - /src/sentry/lang/javascript/ → @getsentry/ingest (15 files) - /src/sentry/billing/ → @getsentry/revenue (13 files) - /src/sentry/debug_files/ → @getsentry/ingest (12 files)
mrduncan
changed the title
CODEOWNERS uses last-match-wins semantics. Several entries were being silently overridden by broader patterns appearing later in the file. Key fixes: - Remove `/src/sentry/api/endpoints/` catch-all (@getsentry/issue-workflow) which was shadowing 36 specific endpoint ownership entries for ingest, data-browsing, security, enterprise, profiling, explore, and other teams - Move Flags section (replay-frontend/backend) below Issues section so issueDetails/ and issues/** overrides apply correctly - Move Frontend section earlier so it doesn't get shadowed - Move event_reprocessable.py into Issues overrides section - Remove shadowed codecov-merge entries (superseded by coding-workflows) - Remove other entries made redundant by broader patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
The changes are more easily reviewable on a commit by commit basis.