Skip to content

test(dashboards): Switch EventsSearchBar test to use paste #110223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scttcper merged 2 commits into from
Mar 9, 2026
Merged

test(dashboards): Switch EventsSearchBar test to use paste #110223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f831f
test(dashboards): Switch EventsSearchBar test to use paste
scttcper Mar 9, 2026
c59db6b
assert something within the test
scttcper Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions .../app/views/dashboards/widgetBuilder/buildSteps/filterResultsStep/eventsSearchBar.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,19 @@ describe('EventsSearchBar', () => {
}
);

// Focus the input and type "has:p" to simulate a search for p50
const input = await screen.findByRole('combobox', {name: 'Add a search term'});
await userEvent.type(input, 'has:p');
await userEvent.click(input, {delay: null});
await userEvent.paste('has:p', {delay: null});

// Check that "p50" (a function tag) is NOT in the dropdown
expect(
within(screen.getByRole('listbox')).queryByText('p50')
).not.toBeInTheDocument();
await userEvent.click(
screen.getByRole('button', {name: 'Edit value for filter: has'})
);

// Assert we actually have has: dropdown options before checking exclusions.
expect(await screen.findByRole('option', {name: 'environment'})).toBeInTheDocument();

// p50 is a function and should not be suggested as a has: tag.
expect(screen.queryByRole('option', {name: 'p50'})).not.toBeInTheDocument();
});

it('shows the selected aggregate in the dropdown', async () => {
Expand Down Expand Up @@ -86,11 +91,11 @@ describe('EventsSearchBar', () => {
);

const input = await screen.findByRole('combobox', {name: 'Add a search term'});

await userEvent.type(input, 'count_uni');
await userEvent.click(input);
await userEvent.paste('count_uni', {delay: null});

expect(
await within(screen.getByRole('listbox')).findByText('count_unique(...)')
await within(await screen.findByRole('listbox')).findByText('count_unique(...)')
).toBeInTheDocument();
});

Expand Down Expand Up @@ -120,10 +125,11 @@ describe('EventsSearchBar', () => {

const input = await screen.findByRole('combobox', {name: 'Add a search term'});
await userEvent.clear(input);
await userEvent.type(input, 'transact');
await userEvent.click(input, {delay: null});
await userEvent.paste('transact', {delay: null});

expect(
await within(screen.getByRole('listbox')).findByRole('option', {
await within(await screen.findByRole('listbox')).findByRole('option', {
name: 'transaction',
})
).toBeInTheDocument();
Expand Down
Loading