Conversation
…t queries The backend DashboardWidgetQuerySerializer requires `fields` and `conditions` for new queries, but several LINE and BIG_NUMBER widget definitions only had `aggregates` defined. This caused validation errors when these prebuilt configs were saved.
github-actions
bot
added
the
Scope: Frontend
mjq
approved these changes
Mar 9, 2026
gggritso
deleted the
georgegritsouk/dain-1298-add-missing-fields-key-to-non-table-prebuilt-widget-queries
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing
fieldskey to LINE and BIG_NUMBER widget querydefinitions in the frontend assets prebuilt dashboard configs.
The backend
DashboardWidgetQuerySerializer.validate()requires bothfieldsandconditionsfor new queries, but several non-table widgetdefinitions only defined
aggregatesandcolumns, omittingfields.This caused validation errors when these prebuilt configs were saved.
For non-table widgets (no group-by),
fieldsmirrorsaggregates.The fix adds this redundant-but-required key to all 11 affected queries
across
frontendAssets.ts(2 widgets) andfrontendAssetsSummary.ts(9 widgets). All other prebuilt configs were audited and already had
fieldsdefined.Fixes DAIN-1298