Conversation
github-actions
bot
added
the
Scope: Backend
Comment on lines
+75
to
+80
| eap_count = count_occurrences_grouped_by_trace_ids( | ||
| snuba_params=snuba_params, | ||
| trace_ids=[trace_id], | ||
| referrer=Referrer.API_TRACE_VIEW_GET_EVENTS.value, | ||
| occurrence_category=OccurrenceCategory.ERROR, | ||
| ).get(trace_id, 0) |
Contributor
There was a problem hiding this comment.
Nit: Do we need grouped_by_trace_ids here? Couldn't we just run a regular Occurrences.run_table_query with query_string=f"trace_id:{trace_id}"? IMO that'd be clearer (since it wouldn't have the grouping postprocessing)... but happy either way.
Member
Author
There was a problem hiding this comment.
Yeah, I thought about that - I ended up going this way to be able to reuse the existing helper and allow the exception handling to just occur there rather than repeat it at the callsite. I would say the main downside is the dict return type (rather than raw int count), but I think I'm okay with that given it's still a relatively simple signature
thetruecpaul
approved these changes
Mar 10, 2026
shashjar
deleted the
shashjar/implement-organization-trace-errors-query-occurrences-on-eap
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements double reads of occurrences from EAP for the errors query in
src/sentry/api/endpoints/organization_trace_meta.py.