Skip to content

feat(size): Migrate size compare build selection page to builds endpoint#110271

Merged
NicoHinderling merged 1 commit intomasterfrom
03-09-feat_size_migrate_size_compare_build_selection_page_to_builds_endpoint
Mar 11, 2026
Merged

feat(size): Migrate size compare build selection page to builds endpoint#110271
NicoHinderling merged 1 commit intomasterfrom
03-09-feat_size_migrate_size_compare_build_selection_page_to_builds_endpoint

Conversation

@NicoHinderling
Copy link
Contributor

@NicoHinderling NicoHinderling commented Mar 9, 2026

Migrate the size compare build selection page from the legacy list-builds endpoint to the builds endpoint.

  • Switch API URL from /preprodartifacts/list-builds/ to /builds/
  • Build a structured query string (state:PROCESSED app_id:... build_configuration_name:...) instead of passing individual query params, to match the builds endpoint's search API
  • Update response type from wrapped ListBuildsApiResponse to flat BuildDetailsApiResponse[] (Link header pagination)
  • Delete the now-unused listBuildsTypes.ts

Depends on #110270.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor Author

NicoHinderling commented Mar 9, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 9, 2026
@NicoHinderling NicoHinderling marked this pull request as ready for review March 9, 2026 23:11
@NicoHinderling NicoHinderling requested a review from a team as a code owner March 9, 2026 23:11
@NicoHinderling NicoHinderling force-pushed the 03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint branch from ab6b708 to 6376d14 Compare March 9, 2026 23:19
@NicoHinderling NicoHinderling force-pushed the 03-09-feat_size_migrate_size_compare_build_selection_page_to_builds_endpoint branch from b0a45e1 to e805912 Compare March 9, 2026 23:19
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing thank you!

@NicoHinderling NicoHinderling force-pushed the 03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint branch from 6376d14 to bca9d97 Compare March 10, 2026 20:53
@NicoHinderling NicoHinderling force-pushed the 03-09-feat_size_migrate_size_compare_build_selection_page_to_builds_endpoint branch from e805912 to 0a04504 Compare March 10, 2026 20:53
Base automatically changed from 03-09-feat_size_ensure_builds_endpoint_has_parity_with_list-builds_endpoint to master March 10, 2026 21:19
@NicoHinderling NicoHinderling force-pushed the 03-09-feat_size_migrate_size_compare_build_selection_page_to_builds_endpoint branch from 0a04504 to 38b56de Compare March 10, 2026 21:20
@NicoHinderling NicoHinderling merged commit e6629d7 into master Mar 11, 2026
61 checks passed
@NicoHinderling NicoHinderling deleted the 03-09-feat_size_migrate_size_compare_build_selection_page_to_builds_endpoint branch March 11, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants