perf(logs): Fix memoization on log row content#110310
Merged
Conversation
Meta was being recreated, and highlight terms was referencing MutableSearch which were both causing identity cycling.
github-actions
bot
added
the
Scope: Frontend
k-fish
commented
Mar 10, 2026
| } | ||
| return terms; | ||
| }, [search, localOnlyItemFilters?.filterText]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Member
Author
There was a problem hiding this comment.
Don't feel like boxing here, it's just more hooks to hide the fake deps.
k-fish
commented
Mar 10, 2026
| ) ?? {fields: {}, units: {}} | ||
| ); | ||
| }, [data]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Member
Author
There was a problem hiding this comment.
Page count should be fine since new pages only are added upon a request firing, and are reset when changing the query.
nsdeschenes
approved these changes
Mar 10, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
656
to
663
| {fields: {}, units: {}} | ||
| ) ?? {fields: {}, units: {}} | ||
| ); | ||
| }, [data]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [pageCount]); | ||
|
|
||
| const _fetchPreviousPage = useCallback(() => { | ||
| if (autoRefresh || hasPreviousPage) { |
Contributor
There was a problem hiding this comment.
Bug: The useMemo hook for _meta has an incomplete dependency array (pageCount), causing it to serve stale metadata when data.pages content changes without altering the page count.
Severity: HIGH
Suggested Fix
The dependency array for the _meta useMemo hook should be corrected to include the data it actually depends on. Instead of [pageCount], it should be [data?.pages] to ensure the memo re-calculates whenever the page data changes.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/explore/logs/useLogsQuery.tsx#L656-L663
Potential issue: The `_meta` variable in `useLogsQuery.tsx` is calculated using a
`useMemo` hook that only has `pageCount` in its dependency array. However, the memo's
callback function accesses the full `data?.pages` object to aggregate metadata. This
creates a staleness bug. When existing page data is updated (e.g., during a refetch)
without changing the total number of pages, the memo will not re-execute. This results
in `_meta` holding stale values for field types and units, which can lead to incorrect
column alignment and data formatting in the logs table. The presence of an
`eslint-disable-next-line react-hooks/exhaustive-deps` comment indicates this was an
intentional but incorrect optimization.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta was being recreated, and highlight terms was referencing MutableSearch which were both causing identity cycling.