feat(traces): add 'Open in Logs' link to Logs view#110311
feat(traces): add 'Open in Logs' link to Logs view#110311JoshuaKGoldberg merged 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
force-pushed
the
trace-logs-to-logs-link
branch
from
89b6219 to
90e3703
Compare
| organization, | ||
| selection, | ||
| query: traceId ? `trace:${traceId}` : undefined, | ||
| }); |
There was a problem hiding this comment.
[Question] I got these added lines from asking Cursor "I need to open the current sentry.io trace in /explore/logs. How do i construct that link?". Is this the right way to do that?
There was a problem hiding this comment.
Yes, typically there are functions that we'll use to create links as theres some repetitiveness to it. Everything here looks fine.
JoshuaKGoldberg
force-pushed
the
trace-logs-to-logs-link
branch
from
90e3703 to
021905f
Compare
JoshuaKGoldberg
force-pushed
the
trace-logs-to-logs-link
branch
from
021905f to
9035db3
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nsdeschenes
left a comment
nsdeschenes
left a comment
There was a problem hiding this comment.
Approving to unblock, everything is fine here as is. Just need that tidy up moving over to a Flex component.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| onSearch={query => setLogsQuery(query)} | ||
| /> | ||
| <LinkButton to={logsUrl}>{t('Open in Logs')}</LinkButton> | ||
| </Flex> |
There was a problem hiding this comment.
Search bar won't stretch to fill available width
Medium Severity
The SearchQueryBuilder inside the Flex container has no flex: 1 or equivalent, so it won't grow to fill the available row width. The existing analogous pattern in ourlogsDrawer.tsx wraps the search builder in <Flex flex="1"> to ensure it stretches. Without this, the search bar will render at its intrinsic width and the LinkButton will sit immediately next to it, leaving empty space on the right — a visible layout regression.
2 participants
Adds a link button to the top-right of Explore > Traces > (trace) > Logs that links to the equivalent query in Explore > Logs.
Fixes LOGS-132