fix(spans): Convert nones to zeros for failure rate and count#110330
Merged
fix(spans): Convert nones to zeros for failure rate and count#110330
Conversation
Nones cause the frontend to render (no value). So convert these to 0s.
Contributor
Backend Test FailuresFailures on
|
wmak
approved these changes
Mar 10, 2026
Contributor
Backend Test FailuresFailures on
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| widget_type=DashboardWidgetTypes.TRANSACTION_LIKE, | ||
| ) | ||
|
|
||
| self.empty_field_widget_query = DashboardWidgetQuery.objects.create( |
Contributor
There was a problem hiding this comment.
Orphaned test fixture left after removing its usage
Low Severity
self.empty_field_widget is still created in setUp but is now unused. The associated empty_field_widget_query and the test_compare_empty_field_tables test that referenced it were both removed in this PR, but the widget fixture itself was left behind. This creates an unnecessary database object on every test run and may confuse future readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Nones cause the frontend to render (no value). So convert these to 0s.