Skip to content

fix(components): [SearchQueryBuilder] cap FilterWrapper width to 2xl less than parent#110334

Merged
JoshuaKGoldberg merged 1 commit intomasterfrom
flex-filter-wrapper-max-width
Mar 11, 2026
Merged

fix(components): [SearchQueryBuilder] cap FilterWrapper width to 2xl less than parent#110334
JoshuaKGoldberg merged 1 commit intomasterfrom
flex-filter-wrapper-max-width

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 10, 2026

The query editor adds "free text" input areas before, between, and after all filters. When a filter takes up full width of the parent then those free texts have to wrap onto their own lines. This change prevents filters from taking up that last 2xl-token-width of space, so wrapping never happens. There's now always a hefty number of pixels for folks to click and start typing free text.

Before After
Screenshot of a narrow Logs header showing a 'message contains long text ...' filter with extra 100% padding above and below the filter Screenshot of a narrow Logs header showing a 'message contains long text ...' filter with very little padding above and below the filter

Fixes LOGS-605

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 10, 2026
@linear-code
Copy link

linear-code bot commented Mar 10, 2026

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review March 10, 2026 18:22
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team March 10, 2026 18:32
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6bd2b62 into master Mar 11, 2026
63 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the flex-filter-wrapper-max-width branch March 11, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants