fix(migrations): Getsentry clean migration #110374
Merged
hubertdeng123 merged 1 commit intomasterfrom Mar 11, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
Member
Author
|
Looks like this works, tested here: https://github.com/getsentry/devinfra-coder-infra/actions/runs/22926563492/job/66538266317?pr=25 |
hubertdeng123
commented
Mar 10, 2026
|
|
||
| dependencies = [ | ||
| ("monitors", "0007_monitors_json_field"), | ||
| ("sentry", "0964_add_commitcomparison_table"), |
Member
Author
There was a problem hiding this comment.
by design this also is a dependency on 0964 since 1040 comes afterwards
hubertdeng123
commented
Mar 10, 2026
|
|
||
| dependencies = [ | ||
| ("sentry", "1039_widget_description_to_textfield"), | ||
| ("monitors", "0008_fix_processing_error_keys"), |
Member
Author
There was a problem hiding this comment.
apparently 0008 needs to run after 1040, not the other way around
wedamija
approved these changes
Mar 10, 2026
markstory
approved these changes
Mar 11, 2026
Member
|
Thanks @hubertdeng123 ❤️ |
hubertdeng123
added a commit
that referenced
this pull request
Mar 16, 2026
follow up to #110374 For self-hosted users, 0008 migration is already applied. 1040 was added last month, so the migration order cannot be done in the order that is expected in the dependency graph. This reverts the migration dependency, and fixes clean migrations so that 0008 no longer uses `sentry_project.template_id` which was breaking for clean installs of getsentry fixes getsentry/self-hosted#4222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the deletion of project templates, clean installation of getsentry from scratch will error out
This job sets up getsentry dev env from scratch.
https://github.com/getsentry/devinfra-coder-infra/actions/runs/22923463253/job/66527712795
Follow up to #110214