ref(grouping): Change where message variable is parameterized#110377
Merged
lobsterkatie merged 3 commits intomasterfrom Mar 11, 2026
Merged
ref(grouping): Change where message variable is parameterized#110377lobsterkatie merged 3 commits intomasterfrom
lobsterkatie merged 3 commits intomasterfrom
Conversation
cvxluo
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small refactor to the code used for variable resolution in custom fingerprints. Recently, we began parameterizing the
{{ message }}variable usingnormalize_message_for_groupinginside ofresolve_fingerprint_variable, but subsequently realized we needed to prevent parameterization when the variable is used for a custom title. Thus we introduced aparameterize_messageparameter toresolve_fingerprint_variable, to control whether or not parameterization runs.This PR is a different (better) solution to the same problem, done in order to both simplify the code and decrease the blast radius of an upcoming change to
normalize_message_for_grouping. Instead of havingparameterize_message: Trueat one of the tworesolve_fingerprint_variablecall sites andparameterize_message: Falseat the other, it just moves the parameterization to the one place whereparameterize_messageis currently true. This lets us get rid of the new parameter, and prevents theparameterize_message: Falsecode from having to compensate for thenormalize_message_for_groupingchanges.