Skip to content

ref(grouping): Change where message variable is parameterized#110377

Merged
lobsterkatie merged 3 commits intomasterfrom
kmclb-change-where-message-variable-is-parameterized
Mar 11, 2026
Merged

ref(grouping): Change where message variable is parameterized#110377
lobsterkatie merged 3 commits intomasterfrom
kmclb-change-where-message-variable-is-parameterized

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Mar 10, 2026

This is a small refactor to the code used for variable resolution in custom fingerprints. Recently, we began parameterizing the {{ message }} variable using normalize_message_for_grouping inside of resolve_fingerprint_variable, but subsequently realized we needed to prevent parameterization when the variable is used for a custom title. Thus we introduced a parameterize_message parameter to resolve_fingerprint_variable, to control whether or not parameterization runs.

This PR is a different (better) solution to the same problem, done in order to both simplify the code and decrease the blast radius of an upcoming change to normalize_message_for_grouping. Instead of having parameterize_message: True at one of the two resolve_fingerprint_variable call sites and parameterize_message: False at the other, it just moves the parameterization to the one place where parameterize_message is currently true. This lets us get rid of the new parameter, and prevents the parameterize_message: False code from having to compensate for the normalize_message_for_grouping changes.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 10, 2026
@lobsterkatie lobsterkatie marked this pull request as ready for review March 10, 2026 23:08
@lobsterkatie lobsterkatie requested a review from a team as a code owner March 10, 2026 23:08
@lobsterkatie lobsterkatie merged commit 66dd35a into master Mar 11, 2026
80 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-change-where-message-variable-is-parameterized branch March 11, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants