ref(nav) rename tour to navigationTour#110387
Merged
JonasBa merged 7 commits intojb/ref/navigation/naming-navfrom Mar 11, 2026
Merged
ref(nav) rename tour to navigationTour#110387JonasBa merged 7 commits intojb/ref/navigation/naming-navfrom
JonasBa merged 7 commits intojb/ref/navigation/naming-navfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
Fix several issues introduced by the tour/stacked nav rename: - SVG import path was '-nav-tour.svg' (missing 'stacked-') — file was not renamed - Tour guide key 'tour._navigation' had a leading underscore; should be 'tour.navigation' - context.tsx used NavigationTourProvider instead of NavigationTourReminderContextProvider, leaving the reminder context never mounted and setShowTourReminder a no-op - Minor: double space in comment and leading space in alt text Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
The tour guide key 'tour.stacked_navigation' is used as an analytics/assistant identifier and must remain stable across refactors. The rename to 'tour.navigation' broke the assistant mock in tests and would have silently broken analytics data. Revert the key to its original value and add a comment to prevent future renames. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| ); | ||
|
|
||
| return stackedNavigationTourData?.seen ?? true; | ||
| return NavigationTourData?.seen ?? true; |
Contributor
There was a problem hiding this comment.
Local variable incorrectly uses PascalCase naming convention
Low Severity
The local variable NavigationTourData uses PascalCase, which in JS/TS convention is reserved for components, classes, and types. The original variable was correctly camelCase (stackedNavigationTourData), but the rename dropped the lowercase prefix, making it look like a React component. It would be navigationTourData to stay consistent with the codebase convention.
TkDodo
approved these changes
Mar 11, 2026
Comment on lines
+121
to
+125
| const NavigationTourData = assistantData?.find( | ||
| item => item.guide === NAVIGATION_TOUR_GUIDE_KEY | ||
| ); | ||
|
|
||
| return stackedNavigationTourData?.seen ?? true; | ||
| return NavigationTourData?.seen ?? true; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const NavigationTourData = assistantData?.find( | |
| item => item.guide === NAVIGATION_TOUR_GUIDE_KEY | |
| ); | |
| return stackedNavigationTourData?.seen ?? true; | |
| return NavigationTourData?.seen ?? true; | |
| const navigationTourData = assistantData?.find( | |
| item => item.guide === NAVIGATION_TOUR_GUIDE_KEY | |
| ); | |
| return navigationTourData?.seen ?? true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove stacked nav wording, rename tour to navigationTour and move the two primary nav components inside the primary folder