Skip to content

fix(preprod): Expose PR comments feature flag to frontend API#110407

Merged
runningcode merged 1 commit intomasterfrom
no/fix/preprod-pr-comments-api-expose
Mar 11, 2026
Merged

fix(preprod): Expose PR comments feature flag to frontend API#110407
runningcode merged 1 commit intomasterfrom
no/fix/preprod-pr-comments-api-expose

Conversation

@runningcode
Copy link
Contributor

@runningcode runningcode commented Mar 11, 2026

Set api_expose=True for the organizations:preprod-build-distribution-pr-comments
feature flag so the frontend <Feature> component can check it.

Without this, the flag is never included in the organization features response,
causing the PR comments toggle to never render on the settings page.

Related to this PR: #110051

And EME-796

@runningcode runningcode marked this pull request as ready for review March 11, 2026 11:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 11, 2026
Copy link

@cameroncooke cameroncooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@runningcode runningcode enabled auto-merge (squash) March 11, 2026 12:06
@github-actions
Copy link
Contributor

Backend Test Failures

Failures on b7df5b3 in this run:

tests/sentry/relay/test_config.py::test_get_project_config[REGION]log
tests/sentry/relay/test_config.py:133: in test_get_project_config
    insta_snapshot(cfg)
E   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
E   Snapshot /home/runner/work/sentry/sentry/tests/sentry/relay/snapshots/test_config/test_get_project_config/REGION.pysnap changed!
E   
E   
E   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.
E   
E   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.
E   
E   
E   --- 
E   
E   +++ 
E   
E   @@ -156,6 +156,7 @@
E   
E          isEnabled: true
E          patterns:
E          - '*healthcheck*'
E   +      - '*health-check*'
E          - '*heartbeat*'
E          - '*/health{/,}'
E          - '*/healthy{/,}'
E   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@github-actions
Copy link
Contributor

Backend Test Failures

Failures on 41b41d8 in this run:

tests/sentry/relay/test_config.py::test_get_project_config[REGION]log
tests/sentry/relay/test_config.py:133: in test_get_project_config
    insta_snapshot(cfg)
E   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
E   Snapshot /home/runner/work/sentry/sentry/tests/sentry/relay/snapshots/test_config/test_get_project_config/REGION.pysnap changed!
E   
E   
E   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.
E   
E   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.
E   
E   
E   --- 
E   
E   +++ 
E   
E   @@ -156,6 +156,7 @@
E   
E          isEnabled: true
E          patterns:
E          - '*healthcheck*'
E   +      - '*health-check*'
E          - '*heartbeat*'
E          - '*/health{/,}'
E          - '*/healthy{/,}'
E   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The frontend Feature component needs api_expose=True to check the
flag. Without it the toggle never renders.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@runningcode runningcode force-pushed the no/fix/preprod-pr-comments-api-expose branch from cc7201f to 22ac79a Compare March 11, 2026 13:20
@runningcode runningcode merged commit afcb051 into master Mar 11, 2026
78 checks passed
@runningcode runningcode deleted the no/fix/preprod-pr-comments-api-expose branch March 11, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants