Skip to content

feat(dashboards): Add starred transaction field to widget builder#110450

Merged
DominikB2014 merged 3 commits intomasterfrom
dominikbuszowiecki/browse-224-add-starred-transaction-field-to-widget-builder
Mar 11, 2026
Merged

feat(dashboards): Add starred transaction field to widget builder#110450
DominikB2014 merged 3 commits intomasterfrom
dominikbuszowiecki/browse-224-add-starred-transaction-field-to-widget-builder

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Mar 11, 2026

Summary

  • Adds is_starred_transaction as a column option in the dashboard widget builder for the Spans dataset
  • Scoped to dashboards only (not Explore) since the starring mutation relies on the dashboard widget query cache
  • Updates StarredSegmentCell to accept an optional projectId prop, making projectSlug optional, starring is only available when project or 'project.idis selected andtransaction`
  • Uses SpanFields enum constants in the field renderer for consistency
image

Fixes BROWSE-224

Test plan

  • Open widget builder, select Spans dataset, switch to Table display
  • Verify is_starred_transaction appears in the column dropdown
  • Add is_starred_transaction column with and without transaction column — star button should be disabled when transaction is absent
  • Verify is_starred_transaction does NOT appear in Explore column picker

Add `is_starred_transaction` as a column option in the dashboard widget
builder for the Spans dataset. This field is scoped to dashboards only
(not Explore) since the starring mutation relies on the dashboard widget
query cache.

Also updates StarredSegmentCell to accept an optional projectId prop
and makes projectSlug optional, allowing the cell to work when only
project ID is available.

Fixes BROWSE-224
@DominikB2014 DominikB2014 requested review from a team as code owners March 11, 2026 18:11
@linear-code
Copy link

linear-code bot commented Mar 11, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 11, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@DominikB2014 DominikB2014 marked this pull request as draft March 11, 2026 18:17
…ropdown

Exclude is_starred_transaction from the "already selected but unknown
columns" section to avoid it appearing twice when selected.
…xplore

Instead of manually adding is_starred_transaction to the widget builder
column list, add it to SENTRY_SPAN_BOOLEAN_TAGS (single source of truth)
and filter it out from Explore via useSpanItemAttributes using a new
DASHBOARD_ONLY_SPAN_ATTRIBUTES constant.

The widget builder uses useTraceItemDatasetAttributes directly, so it
still sees the field. Explore uses useSpanItemAttributes which now
automatically excludes dashboard-only attributes.
@DominikB2014 DominikB2014 marked this pull request as ready for review March 11, 2026 18:28
@DominikB2014 DominikB2014 merged commit fa9090c into master Mar 11, 2026
62 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-224-add-starred-transaction-field-to-widget-builder branch March 11, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants