ref(code_review): remove legacy endpoint#110457
Merged
Conversation
… to use new review-request endpoints This commit removes the `coding_workflows.code_review.seer.use_new_endpoints` option, which was previously used to toggle between legacy and new endpoints for GitHub webhook events. All relevant tests have been updated to consistently use the new `review-request` and `pr-closed` endpoints. The code has been adjusted to reflect these changes, ensuring that the new endpoints are utilized for processing pull request and issue comment events.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Mar 11, 2026
| return { | ||
| # In Seer,src/seer/routes/automation_request.py:overwatch_request_endpoint | ||
| # Payload shape consumed by Seer code_review routes (review-request, pr-closed). | ||
| "request_type": request_type.value, |
Member
Author
There was a problem hiding this comment.
request_type is no longer needed but we will remove it in another PR.
| github_event=GithubWebhookType.CHECK_RUN, | ||
| event_payload={"original_run_id": self.original_run_id}, | ||
| enqueued_at_str=self.enqueued_at_str, | ||
| tags={}, |
Member
Author
There was a problem hiding this comment.
This is kind of unrelated. On a different branch, I intend to make tags a required field rather than optional.
| with ( | ||
| self.code_review_setup(), | ||
| self.tasks(), | ||
| self.options({"coding_workflows.code_review.seer.use_new_endpoints": True}), |
Member
Author
There was a problem hiding this comment.
The option is no longer needed, thus, we can fold into a single test.
| with ( | ||
| self.code_review_setup(), | ||
| self.tasks(), | ||
| self.options({"coding_workflows.code_review.seer.use_new_endpoints": True}), |
Member
Author
There was a problem hiding this comment.
The option is no longer needed, thus, we can fold into a single test.
| with ( | ||
| self.code_review_setup(), | ||
| self.tasks(), | ||
| self.options({"coding_workflows.code_review.seer.use_new_endpoints": True}), |
Member
Author
There was a problem hiding this comment.
The option is no longer needed, thus, we can fold into a single test.
srest2021
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
coding_workflows.code_review.seer.use_new_endpointsoption, which was previously used to toggle between legacy (overwatch-request) and the new Code Review endpoints for GitHub webhook events. All relevant tests have been updated to consistently use the newreview-requestandpr-closedendpoints. The code has been adjusted to reflect these changes, ensuring that the new endpoints are utilized for processing pull request and issue comment events.