fix(agents): Add error boundary around ModelsTable#110509
Merged
priscilawebdev merged 2 commits intomasterfrom Mar 13, 2026
Merged
fix(agents): Add error boundary around ModelsTable#110509priscilawebdev merged 2 commits intomasterfrom
priscilawebdev merged 2 commits intomasterfrom
Conversation
Wrap ModelsTable with an ErrorBoundary so that rendering errors in the models table (e.g. null modelId) are contained instead of crashing the entire page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Mar 12, 2026
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
Makes sense, though why are the types lying about modelId? If it's possible for that to error at runtime, we should change the type!
Member
Author
I did update the types in the PR https://github.com/getsentry/sentry/pull/110505/changes 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap
ModelsTablewith<ErrorBoundary mini>on the agent models landing page so that rendering errors (e.g. nullmodelIdhitting.toLowerCase()) are contained within the table instead of crashing the entire page.This follows the existing pattern of wrapping table consumers at the call site. The widget footer error boundary was added in #110506 but
ModelsTable(a standaloneGridEditabletable) was unprotected.Refs #110505