Skip to content

partial-revert(llm-detection): Revert frontend issue type filtering#110565

Merged
nora-shap merged 1 commit intomasterfrom
nora/ID-1380
Mar 12, 2026
Merged

partial-revert(llm-detection): Revert frontend issue type filtering#110565
nora-shap merged 1 commit intomasterfrom
nora/ID-1380

Conversation

@nora-shap
Copy link
Member

partially reverts #109929 - the issue type filtering is now done at the api (#110356) which makes the frontend filtering redundant.

removes:

  • addOccurrence() method and its HIDDEN_OCCURRENCE_TYPE_IDS filtering
  • The test for addOccurrence filtering
  • All addOccurrence() calls → back to occurrences.add()

keeps:

  • EAPOccurrence.issue_type field name (bug fix)
  • anrRootCause.tsx handling of both type and issue_type
    • Unfortunately, TraceOccurrence = TracePerformanceIssue | EAPOccurrence. TracePerformanceIssue uses type while EAPOccurrence now uses issue_type so both fields need to be checked on a TraceOccurrence.

@nora-shap nora-shap requested a review from shayna-ch March 12, 2026 19:05
@nora-shap nora-shap requested a review from a team as a code owner March 12, 2026 19:05
@linear-code
Copy link

linear-code bot commented Mar 12, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 12, 2026
@nora-shap nora-shap merged commit 1cea9f4 into master Mar 12, 2026
63 checks passed
@nora-shap nora-shap deleted the nora/ID-1380 branch March 12, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants