Skip to content

ref(preprod): Sidebar polish#110571

Merged
rbro112 merged 1 commit intomasterfrom
ryan/sidebar_polish
Mar 12, 2026
Merged

ref(preprod): Sidebar polish#110571
rbro112 merged 1 commit intomasterfrom
ryan/sidebar_polish

Conversation

@rbro112
Copy link
Member

@rbro112 rbro112 commented Mar 12, 2026

Fixes EME-924. This was a bit tricky as emotion styling didn't work on Disclosure.Title as there seems to be a bug where ...rest is passed to the child button rather than the top-level Flex. This required me to essentially implement a custom Disclosure.Title with a Button, but works pretty well overall.

Before:
Screenshot 2026-03-12 at 11 20 10 AM

After:
Screenshot 2026-03-12 at 12 51 32 PM
Screenshot 2026-03-12 at 12 51 26 PM

Designs (after matches):
https://www.figma.com/design/noaq47E7GgvQhcRNxj5OAF/Emerge-Merge?node-id=3298-2462&t=YVvX3NErHrgtNHpV-1

@rbro112 rbro112 requested a review from a team as a code owner March 12, 2026 19:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 12, 2026
Copy link
Member Author

rbro112 commented Mar 12, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear-code
Copy link

linear-code bot commented Mar 12, 2026

@rbro112 rbro112 changed the title Sidebar polish feat(preprod): Sidebar polish Mar 12, 2026
@rbro112 rbro112 changed the title feat(preprod): Sidebar polish ref(preprod): Sidebar polish Mar 12, 2026
@rbro112 rbro112 merged commit 40e8f07 into master Mar 12, 2026
70 checks passed
@rbro112 rbro112 deleted the ryan/sidebar_polish branch March 12, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants