Conversation
github-actions
bot
added
the
Scope: Backend
shashjar
commented
Mar 12, 2026
shashjar
commented
Mar 12, 2026
| elif isinstance(value, float): | ||
| return AnyValue(double_value=value) | ||
| elif isinstance(value, list) or isinstance(value, tuple): | ||
| # Not yet processed on EAP side |
Member
Author
There was a problem hiding this comment.
Removing because arrays are being processed EAP-side, only objects are not currently
shashjar
commented
Mar 12, 2026
shashjar
commented
Mar 12, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
thetruecpaul
approved these changes
Mar 16, 2026
Contributor
thetruecpaul
left a comment
thetruecpaul
left a comment
There was a problem hiding this comment.
LGTM! Good addition :-)
shashjar
commented
Mar 16, 2026
| occurrence = event.occurrence | ||
| if occurrence is not None: | ||
| out["issue_occurrence_id"] = str(occurrence.id) | ||
| out["group_type_id"] = int(occurrence.type.type_id) |
Member
Author
There was a problem hiding this comment.
Defensive / redundant casts here to make sure we ingest the right types into EAP
shashjar
deleted the
shashjar/ingest-issue-platform-occurrence-data-into-eap
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/sentry/Occurrences-on-EAP-Ingestion-3218b10e4b5d8080bf28c081cb69b6a1?source=copy_link#3218b10e4b5d80259a0fc72d45bc5598
We're currently not ingesting issue platform occurrence data (
occurrence_id,occurrence_type_id) into EAP on occurrence trace items. This PR adds those fields to the EAP ingestion flow.Note that we're renaming these fields to
issue_occurrence_id&group_type_idupon ingestion into EAP in order to avoid confusion with the "occurrences" that we refer to as trace items in the context of EAP.