Skip to content

feat(occurrences on eap): Update attribute definitions#110587

Merged
shashjar merged 10 commits intomasterfrom
shashjar/update-occurrences-on-eap-attribute-definitions
Mar 16, 2026
Merged

feat(occurrences on eap): Update attribute definitions#110587
shashjar merged 10 commits intomasterfrom
shashjar/update-occurrences-on-eap-attribute-definitions

Conversation

@shashjar
Copy link
Member

@shashjar shashjar commented Mar 12, 2026

https://www.notion.so/sentry/Occurrences-on-EAP-Ingestion-3218b10e4b5d8080bf28c081cb69b6a1?source=copy_link#3218b10e4b5d80d89594e0284cfde606

Bringing attribute definitions for occurrence trace items up to date with the current EAP ingestion flow.

@shashjar shashjar changed the base branch from master to shashjar/ingest-issue-platform-occurrence-data-into-eap March 12, 2026 21:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 12, 2026
internal_name="http_method",
search_type="string",
),
ResolvedAttribute(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the public alias for this attribute remains http.referer for backward compatibility, but we're storing it internally in EAP as http_referrer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am starting to think that we should just have it referer[sic] everywhere for consistency 😓 ... let's chat in our sync today

@shashjar shashjar requested review from a team and thetruecpaul March 13, 2026 21:38
@shashjar shashjar marked this pull request as ready for review March 13, 2026 21:38
@shashjar shashjar requested a review from a team as a code owner March 13, 2026 21:38
internal_name="http_method",
search_type="string",
),
ResolvedAttribute(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am starting to think that we should just have it referer[sic] everywhere for consistency 😓 ... let's chat in our sync today

Base automatically changed from shashjar/ingest-issue-platform-occurrence-data-into-eap to master March 16, 2026 18:45
@shashjar shashjar requested a review from a team as a code owner March 16, 2026 18:45
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

Backend Test Failures

Failures on 5b302fa in this run:

tests/sentry/spans/test_buffer.py::test_schema_examples[cluster-nochunk-span_with_accepted_outcome]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[single-chunk1-basic_span]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[cluster-nochunk-basic_span]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[single-chunk1-null_fields]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[single-chunk1-span_with_accepted_outcome]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[cluster-nochunk-null_fields]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[cluster-chunk1-basic_span]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[single-nochunk-span_with_accepted_outcome]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[single-nochunk-basic_span]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[single-nochunk-null_fields]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[cluster-chunk1-span_with_accepted_outcome]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'
tests/sentry/spans/test_buffer.py::test_schema_examples[cluster-chunk1-null_fields]log
tests/sentry/spans/test_buffer.py:1616: in test_schema_examples
    span = Span(
E   TypeError: Span.__new__() got an unexpected keyword argument 'end_timestamp'

@shashjar shashjar merged commit 342dcbb into master Mar 16, 2026
78 checks passed
@shashjar shashjar deleted the shashjar/update-occurrences-on-eap-attribute-definitions branch March 16, 2026 20:26
JonasBa pushed a commit that referenced this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants