Skip to content

feat(occurrences on eap): Fix OccurrenceCategory filtering in query layer#110591

Merged
shashjar merged 18 commits intomasterfrom
shashjar/fix-occurrence-category-filtering-occurrences-on-eap
Mar 16, 2026
Merged

feat(occurrences on eap): Fix OccurrenceCategory filtering in query layer#110591
shashjar merged 18 commits intomasterfrom
shashjar/fix-occurrence-category-filtering-occurrences-on-eap

Conversation

@shashjar
Copy link
Member

@shashjar shashjar commented Mar 12, 2026

https://www.notion.so/sentry/Occurrences-on-EAP-Ingestion-3218b10e4b5d8080bf28c081cb69b6a1?source=copy_link#3218b10e4b5d80fda14ec70ddc848b1e

The filter to distinguish error event occurrence trace items from issue platform event occurrence trace items should rely on the presence or absence of an occurrence_id field on the occurrence trace item. An occurrence trace item is an issue platform event iff it has an associated occurrence via the occurrence_id field.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 12, 2026
shashjar
shashjar commented Mar 12, 2026
View reviewed changes
src/sentry/snuba/occurrences_rpc.py

ERROR = "error"
GENERIC = "generic"
ISSUE_PLATFORM = "issue_platform"
Copy link
Member Author

@shashjar shashjar Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming to ISSUE_PLATFORM to have a clearer name (open to better suggestions)

shashjar
shashjar commented Mar 12, 2026
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026 •
edited
Loading

Backend Test Failures

Failures on 2ca8fba in this run:

tests/snuba/api/endpoints/test_organization_trace_meta.py::OrganizationEventsTraceMetaEndpointTest::test_simple_with_eap_as_source_of_truth — log 
tests/snuba/api/endpoints/test_organization_trace_meta.py:132: in test_simple_with_eap_as_source_of_truth
    assert data["performance_issues"] == 2
E   assert 0 == 2
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_project_key_performance_issues_eap_matches_snuba — log 
tests/sentry/tasks/test_weekly_reports.py:416: in test_project_key_performance_issues_eap_matches_snuba
    assert len(eap_rows) == 2
E   assert 0 == 2
E    +  where 0 = len([])
tests/snuba/api/endpoints/test_organization_events_trace.py::OrganizationEventsTraceMetaEndpointTest::test_simple_with_eap_as_source_of_truth — log 
tests/snuba/api/endpoints/test_organization_events_trace.py:1553: in test_simple_with_eap_as_source_of_truth
    assert data["performance_issues"] == 2
E   assert 0 == 2

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026 •
edited
Loading

Backend Test Failures

Failures on 4a1a0c8 in this run:

tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_project_key_performance_issues_eap_matches_snuba — log 
tests/sentry/tasks/test_weekly_reports.py:416: in test_project_key_performance_issues_eap_matches_snuba
    assert len(eap_rows) == 2
E   assert 0 == 2
E    +  where 0 = len([])
tests/snuba/api/endpoints/test_organization_trace_meta.py::OrganizationEventsTraceMetaEndpointTest::test_simple_with_eap_as_source_of_truth — log 
tests/snuba/api/endpoints/test_organization_trace_meta.py:132: in test_simple_with_eap_as_source_of_truth
    assert data["performance_issues"] == 2
E   assert 0 == 2
tests/snuba/api/endpoints/test_organization_events_trace.py::OrganizationEventsTraceMetaEndpointTest::test_simple_with_eap_as_source_of_truth — log 
tests/snuba/api/endpoints/test_organization_events_trace.py:1553: in test_simple_with_eap_as_source_of_truth
    assert data["performance_issues"] == 2
E   assert 0 == 2

@shashjar shashjar requested review from a team and thetruecpaul March 13, 2026 21:40
@shashjar shashjar marked this pull request as ready for review March 13, 2026 21:40
@shashjar shashjar requested review from a team as code owners March 13, 2026 21:40
@shashjar
Merge branch 'shashjar/update-occurrences-on-eap-attribute-definition…
14a0c35 
…s' into shashjar/fix-occurrence-category-filtering-occurrences-on-eap
@shashjar shashjar removed the request for review from a team March 13, 2026 21:40
thetruecpaul
thetruecpaul approved these changes Mar 16, 2026
View reviewed changes
Copy link
Contributor

@thetruecpaul thetruecpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as is — thanks for leading on this :-)

Base automatically changed from shashjar/update-occurrences-on-eap-attribute-definitions to master March 16, 2026 20:26
@shashjar shashjar merged commit a0b51d7 into master Mar 16, 2026
78 checks passed
@shashjar shashjar deleted the shashjar/fix-occurrence-category-filtering-occurrences-on-eap branch March 16, 2026 21:03
JonasBa pushed a commit that referenced this pull request Mar 16, 2026
@shashjar @JonasBa
feat(occurrences on eap): Fix OccurrenceCategory filtering in query…
aace948 
… layer (#110591)

https://www.notion.so/sentry/Occurrences-on-EAP-Ingestion-3218b10e4b5d8080bf28c081cb69b6a1?source=copy_link#3218b10e4b5d80fda14ec70ddc848b1e

The filter to distinguish error event occurrence trace items from issue
platform event occurrence trace items should rely on the presence or
absence of an `occurrence_id` field on the occurrence trace item. An
occurrence trace item is an issue platform event iff it has an
associated occurrence via the `occurrence_id` field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetruecpaul thetruecpaul thetruecpaul approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shashjar @thetruecpaul