ref(grouping): Improve message parameterization metrics#110612
Merged
lobsterkatie merged 5 commits intomasterfrom Mar 13, 2026
Merged
ref(grouping): Improve message parameterization metrics#110612lobsterkatie merged 5 commits intomasterfrom
lobsterkatie merged 5 commits intomasterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
7a47d5b to
bec3b75
Compare
8c97176 to
e11bcd0
Compare
shashjar
reviewed
Mar 13, 2026
shashjar
reviewed
Mar 13, 2026
shashjar
approved these changes
Mar 13, 2026
Member
shashjar
left a comment
There was a problem hiding this comment.
left a couple of suggestions
Base automatically changed from
kmclb-cache-parameterized-version-of-message-variable
to
master
March 13, 2026 18:53
e11bcd0 to
00752a1
Compare
00752a1 to
a16ea80
Compare
a16ea80 to
4efa932
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a number of adjustments to our parameterization metrics, both to improve them and to reflect recent changes to the code.
Right now, we have a
message_parameterizedmetric, which only fires when the parameterized message doesn't match the original message, not every time we run parameterization. We therefore can't answer the question of how often parameterization has any effect. To answer that question, this adds a new metric inside theparameterizefunction,parameterizer_called, which fires any time the function runs, and which includes a booleanchangedtag.Now that we cache parameterization results, firing the
message_parameterizedmetric any timenormalize_message_for_groupingis called isn't actually accurate anymore. This therefore replaces it with a newmessage_usedmetric, so that we can continue to track our various reasons for using messages.Caching parameterization results doesn't actually make things any better if we only use the cached value once. To better track how effective caching is, this adds to the context usage flags for both the parameterization result and the parameterizer itself (which is also cached, to save us having to check which one to use over and over). These are then checked (and flipped to
Trueif they weren't already) each time we use one, and new metrics (cached_param_result_usedandcached_parameterizer_used, respectively) are fired any time the flag indicates multiple usages.