ref(settings): migrate integration org settings#110666
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/app/components/backendJsonFormAdapter/choiceMapperAdapter.tsx
Outdated
Show resolved
Hide resolved
natemoo-re
approved these changes
Mar 17, 2026
| case 'string': | ||
| case 'text': | ||
| case 'url': | ||
| case 'email': |
Member
There was a problem hiding this comment.
Should we use z.email()? Not sure how strict our validation is currently.
| return z.boolean(); | ||
| case 'string': | ||
| case 'text': | ||
| case 'url': |
Comment on lines
+294
to
+297
| value={fieldApi.state.value} | ||
| onChange={fieldApi.handleChange} | ||
| placeholder={field.placeholder} | ||
| disabled={field.disabled} |
Member
There was a problem hiding this comment.
Would be nice to preserve types for url and email here for browser suggestions?
Member
There was a problem hiding this comment.
[Praise] These are well done!
| mutationFn: (data: Record<string, unknown>) => | ||
| fetchMutation({method: 'POST', url: integrationEndpoint, data}), | ||
| onSuccess: () => { | ||
| return queryClient.invalidateQueries({ |
Member
There was a problem hiding this comment.
Seems like a reasonable trade-off. It'd be nice to add your comment here as an inline comment for future visitors!
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
JonasBa
pushed a commit
that referenced
this pull request
Mar 18, 2026
This PR adds a mapping layer for when the backend sends a json structure, so that we can render form fields with the new scraps form system based on them. A lot of field types are supported out of the box, and this PR also adds 3 custom fields for the following field types: - choice_mapper - project_mapper - table The `BackendJsonFormAdapter` is then used for `organizationIntegration`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a mapping layer for when the backend sends a json structure, so that we can render form fields with the new scraps form system based on them.
A lot of field types are supported out of the box, and this PR also adds 3 custom fields for the following field types:
The
BackendJsonFormAdapteris then used fororganizationIntegration.