Skip to content

feat(autofix): Support user feedback in autofix steps#110694

Merged
Zylphrex merged 4 commits intomasterfrom
txiao/feat/support-user-feedback-in-autofix-steps
Mar 16, 2026
Merged

feat(autofix): Support user feedback in autofix steps#110694
Zylphrex merged 4 commits intomasterfrom
txiao/feat/support-user-feedback-in-autofix-steps

Conversation

@Zylphrex
Copy link
Member

This adds support for allowing users to provide feedback when running an autofix step by appending the user feedback to the end of the prompt.

This adds support for allowing users to provide feedback when running an autofix
step by appending the user feedback to the end of the prompt.
@Zylphrex Zylphrex requested a review from a team as a code owner March 13, 2026 22:15
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 13, 2026
@github-actions
Copy link
Contributor

Backend Test Failures

Failures on 678971c in this run:

tests/sentry/seer/autofix/test_autofix_agent.py::TestBuildStepPrompt::test_all_prompts_are_dedentedlog
tests/sentry/seer/autofix/test_autofix_agent.py:248: in test_all_prompts_are_dedented
    prompt = build_step_prompt(step, self.group)
E   TypeError: build_step_prompt() missing 1 required positional argument: 'user_feedback'
tests/sentry/seer/autofix/test_autofix_agent.py::TestBuildStepPrompt::test_code_changes_prompt_contains_issue_detailslog
tests/sentry/seer/autofix/test_autofix_agent.py:213: in test_code_changes_prompt_contains_issue_details
    prompt = build_step_prompt(AutofixStep.CODE_CHANGES, self.group)
E   TypeError: build_step_prompt() missing 1 required positional argument: 'user_feedback'
tests/sentry/seer/autofix/test_autofix_agent.py::TestBuildStepPrompt::test_impact_assessment_prompt_contains_issue_detailslog
tests/sentry/seer/autofix/test_autofix_agent.py:221: in test_impact_assessment_prompt_contains_issue_details
    prompt = build_step_prompt(AutofixStep.IMPACT_ASSESSMENT, self.group)
E   TypeError: build_step_prompt() missing 1 required positional argument: 'user_feedback'
tests/sentry/seer/autofix/test_autofix_agent.py::TestBuildStepPrompt::test_prompt_with_missing_culprit_uses_defaultlog
tests/sentry/seer/autofix/test_autofix_agent.py:242: in test_prompt_with_missing_culprit_uses_default
    prompt = build_step_prompt(AutofixStep.ROOT_CAUSE, self.group)
E   TypeError: build_step_prompt() missing 1 required positional argument: 'user_feedback'
tests/sentry/seer/autofix/test_autofix_agent.py::TestBuildStepPrompt::test_root_cause_prompt_contains_issue_detailslog
tests/sentry/seer/autofix/test_autofix_agent.py:195: in test_root_cause_prompt_contains_issue_details
    prompt = build_step_prompt(AutofixStep.ROOT_CAUSE, self.group)
E   TypeError: build_step_prompt() missing 1 required positional argument: 'user_feedback'
tests/sentry/seer/autofix/test_autofix_agent.py::TestBuildStepPrompt::test_solution_prompt_contains_issue_detailslog
tests/sentry/seer/autofix/test_autofix_agent.py:204: in test_solution_prompt_contains_issue_details
    prompt = build_step_prompt(AutofixStep.SOLUTION, self.group)
E   TypeError: build_step_prompt() missing 1 required positional argument: 'user_feedback'
tests/sentry/seer/autofix/test_autofix_agent.py::TestBuildStepPrompt::test_triage_prompt_contains_issue_detailslog
tests/sentry/seer/autofix/test_autofix_agent.py:230: in test_triage_prompt_contains_issue_details
    prompt = build_step_prompt(AutofixStep.TRIAGE, self.group)
E   TypeError: build_step_prompt() missing 1 required positional argument: 'user_feedback'

Copy link
Member

@shruthilayaj shruthilayaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small naming nit: should we name this "additional user context" or something along those lines to avoid clash with our user feedback feature?

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@github-actions
Copy link
Contributor

Backend Test Failures

Failures on 89a9029 in this run:

tests/sentry/seer/endpoints/test_group_ai_autofix.py::GroupAutofixEndpointExplorerRoutingTest::test_stopping_pointlog
tests/sentry/seer/endpoints/test_group_ai_autofix.py:913: in test_stopping_point
    mock_trigger_explorer.assert_called_once_with(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:989: in assert_called_once_with
    return self.assert_called_with(*args, **kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:977: in assert_called_with
    raise AssertionError(_error_message()) from cause
E   AssertionError: expected call not found.
E   Expected: trigger_autofix_explorer(group=<Group at 0x7f8a05cdf610: id=45, project_id=4557802902847488>, step=<AutofixStep.ROOT_CAUSE: 'root_cause'>, stopping_point=<AutofixStoppingPoint.CODE_CHANGES: 'code_changes'>, run_id=None, intelligence_level='low', user_feedback=None)
E     Actual: trigger_autofix_explorer(group=<Group at 0x7f8a05cdee90: id=45, project_id=4557802902847488>, step=<AutofixStep.ROOT_CAUSE: 'root_cause'>, stopping_point=<AutofixStoppingPoint.CODE_CHANGES: 'code_changes'>, run_id=None, intelligence_level='low', user_context=None)

@Zylphrex Zylphrex merged commit f146a39 into master Mar 16, 2026
57 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/support-user-feedback-in-autofix-steps branch March 16, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants