fix(seer): Handle enum deserialization in autofix tasks#110959
Draft
sentry[bot] wants to merge 2 commits intomasterfrom
Draft
fix(seer): Handle enum deserialization in autofix tasks#110959sentry[bot] wants to merge 2 commits intomasterfrom
sentry[bot] wants to merge 2 commits intomasterfrom
Conversation
Mihir-Mavalankar
approved these changes
Mar 18, 2026
Contributor
|
Not sure why this only affects automations you org though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
NoRetriesRemainingErroroccurring insentry.tasks.autofix.trigger_autofix_from_issue_summary, which was caused by anAttributeError: 'str' object has no attribute 'value'.Problem:
When
AutofixStoppingPointandAutofixReferrerenum instances are passed as parameters to the_trigger_autofix_taskCelery task, the Celery serialization process converts these enums into their string representations (e.g.,'root_cause'). Upon deserialization, the task receives these parameters as plain strings, not asStrEnumobjects. Downstream functions, such astrigger_autofix_explorer, then attempt to access the.valueattribute on these string objects, leading to anAttributeError.Solution:
_trigger_autofix_tasksignature: Modified the type annotations forstopping_pointandreferrerparameters insrc/sentry/seer/autofix/issue_summary.pytoAutofixStoppingPoint | str | NoneandAutofixReferrer | strrespectively. This clarifies that the task can receive these parameters as either enum instances or their string values after deserialization._trigger_autofix_taskfunction to explicitly convertstopping_pointandreferrerback into their respectiveStrEnumtypes if they are received as strings. This ensures that by the time these parameters are used by downstream functions, they are always proper enum instances.This fix ensures that the task correctly handles the deserialization of enum parameters, preventing the
AttributeErrorand the subsequent task retry exhaustion.Fixes SENTRY-5AYM
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.