feat(api): Support Project ID and Slugs in OrganizationArtifactBundleAssembleEndpoint#74232
Merged
iamrajjoshi merged 4 commits intomasterfrom Jul 15, 2024
Merged
feat(api): Support Project ID and Slugs in OrganizationArtifactBundleAssembleEndpoint#74232iamrajjoshi merged 4 commits intomasterfrom
OrganizationArtifactBundleAssembleEndpoint#74232iamrajjoshi merged 4 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74232 +/- ##
=======================================
Coverage 78.12% 78.13%
=======================================
Files 6665 6665
Lines 297919 297927 +8
Branches 51280 51282 +2
=======================================
+ Hits 232764 232772 +8
- Misses 58878 58882 +4
+ Partials 6277 6273 -4
|
schew2381
reviewed
Jul 12, 2024
src/sentry/api/endpoints/organization_artifactbundle_assemble.py
Outdated
Show resolved
Hide resolved
src/sentry/api/endpoints/organization_artifactbundle_assemble.py
Outdated
Show resolved
Hide resolved
schew2381
approved these changes
Jul 15, 2024
Contributor
schew2381
left a comment
schew2381
left a comment
There was a problem hiding this comment.
some nits but overall lgtm!
src/sentry/api/endpoints/organization_artifactbundle_assemble.py
Outdated
Show resolved
Hide resolved
| assert response.status_code == 400, response.content | ||
| assert response.data["error"] == "One or more projects are invalid" | ||
|
|
||
| def test_assemble_with_valid_project_slugs(self): |
Contributor
There was a problem hiding this comment.
subjective nit: maybe this test isn't needed b/c we're using project slug already for everything else? This is prob more subjective tho cuz maybe it's good to explicitly test anyways. Up to you
iamrajjoshi
force-pushed
the
raj/api/id-support-for-aba
branch
from
9ef3636 to
b1da53b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on getting all the commands in our Sentry CLI to support Ids as well as Slugs. rough spec
We have already gone through the effort of supporting ids and slugs in path parameters of all the APIs in our codebase. There are some endpoints that the CLI uses that pass in project slugs as body parameters, so we need to support Ids for those as well.
Here, I use the fact that ids are numeric and slugs aren't to process both type of identifiers.