fix(dropdownmenu): Make submenu dismissable#94740
Merged
Conversation
fixes an issue with the next version of jsdom where the dropdown doesn't close when clicking outside. As far as i can tell the behavior is the same with or without these options. unblocks #93303
github-actions
bot
added
the
Scope: Frontend
ryan953
approved these changes
Jul 1, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes an issue with the next version of jsdom where the dropdown doesn't close when clicking outside. As far as i can tell the behavior is the same with or without these options.
unblocks #93303