Respect aws_profile from Keygroup Config#1049
Merged
hiddeco merged 3 commits intogetsops:mainfrom Oct 13, 2023
Merged
Conversation
|
I can confirm that this patch fixes the bug that prevents sample .sops.yml---
creation_rules:
- key_groups:
- kms:
- arn: arn:aws:kms:eu-west-1......
aws_profile: my-profileWith latest
|
|
Oh this was the issue I had here. Would love to see it merged :) |
|
Any chance somehow can review/approve ? this would be very useful |
rafzei
approved these changes
Aug 29, 2022
Contributor
|
@Kouzukii can you change this to be against |
e1958ce to
2714ec1
Compare
Contributor
Author
|
@ajvb done |
|
almost there :) can someone review it please ? |
|
@ajvb : Could you review this PR please ? |
|
bump |
Closed
Signed-off-by: Benjamin Ludewig <benjamin.ludewig@neuland-bfi.de>
Signed-off-by: Benjamin Ludewig <benjamin.ludewig@neuland-bfi.de>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A KMS entry in a creation_rule keygroup supports setting aws_profile, but the value is not passed into the KMS MasterKey.
Fixes: #1093