Merged
Conversation
Signed-off-by: Tanner Storment <tannerstorment@gmail.com>
felixfontein
approved these changes
Dec 10, 2023
Contributor
|
@stormentt thanks a lot for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my stock Ubuntu 22.04 machine with Go 1.21 one of the tests fails:
The test assumes that
t.TempDir()returns a directory with mode0755.Taking a look at testing.go:1221 shows that this uses os.MkdirTemp(), which calls
Mkdir(name, 0700), causing the test to fail.To fix this I modified the test to explicitly set the mode on the tempdir to 0755.