Avoid deleting children multiple times while purging old tasks#1254
Merged
diegogangl merged 1 commit intogetting-things-gnome:masterfrom Dec 22, 2025
Merged
Avoid deleting children multiple times while purging old tasks#1254diegogangl merged 1 commit intogetting-things-gnome:masterfrom
diegogangl merged 1 commit intogetting-things-gnome:masterfrom
Conversation
Use BaseStore.batch_remove to avoid deleting the same closed task multiple times in Application.purge_old_tasks. (E.g., the task is first deleted as the child of another closed task, and then a second delete is attempted because the task is also present in 'to_remove'). This fixes GitHub issue getting-things-gnome#1247.
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1247
GTG tried to delete the same closed task multiple times. E.g., the task is first deleted as the child of another closed task, and then a second delete is attempted because the task is also present in
to_remove. UsingBaseStore.batch_removeavoids this problem.