[wgpu] add convience functions for deferring mapping/callbacks#8125
Merged
Wumpf merged 1 commit intogfx-rs:trunkfrom Sep 7, 2025
Merged
[wgpu] add convience functions for deferring mapping/callbacks#8125Wumpf merged 1 commit intogfx-rs:trunkfrom
Wumpf merged 1 commit intogfx-rs:trunkfrom
Conversation
e910b48 to
e42ba38
Compare
kpreid
suggested changes
Aug 23, 2025
63ad459 to
d43a9bf
Compare
Wumpf
approved these changes
Sep 1, 2025
Member
Wumpf
left a comment
There was a problem hiding this comment.
neat!
I think it's rather unfortunate to have this kind of extension in wgpu proper rather than an extension to it. Makes me wonder whether those deferred commands could be more generic and then we expose the concrete buffer extension as a utility.... but I don't want to throw a wrench into a perfectly good feature that is really hard to get into the ecosystem if we don't put it in here. So overall slight scope creep concerns, but let's ship this anyways!
04f181e to
9f3694a
Compare
Co-authored-by: Kevin Reid <kpreid@switchb.org>
9f3694a to
018772d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
None
Description
This adds various functions for making dealing with mapping and other callbacks easier. Often you are working with a command buffer then want to map a buffer or do something when that command buffer is submitted. Normally you need to build some kind of infrastructure for this (I have many times) but this can be really easily be done by wgpu itself for very little cost.
Testing
Told GPT-5 to put together some tests as an experiment. I think it did okay.
Squash or Rebase?
Rebase me pls
Checklist