fix: Change max_*_buffer_binding_size type to match WebGPU spec#9146
Merged
ErichDonGubler merged 3 commits intogfx-rs:trunkfrom Mar 9, 2026
Merged
fix: Change max_*_buffer_binding_size type to match WebGPU spec#9146ErichDonGubler merged 3 commits intogfx-rs:trunkfrom
max_*_buffer_binding_size type to match WebGPU spec#9146ErichDonGubler merged 3 commits intogfx-rs:trunkfrom
Conversation
ErichDonGubler
force-pushed
the
fix/max-buffer-binding-size
branch
from
5ddff14 to
2fa305b
Compare
ErichDonGubler
approved these changes
Mar 6, 2026
Member
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
LGTM, minus some nits I resolved on my own. I squashed down your changes, and added some of my own. The fixup! commits are intended to be squashed again. What do you think? If they look good to you, I'll squash 'em, and rebase-and-merge the rest.
ErichDonGubler
added
type: enhancement
ErichDonGubler
force-pushed
the
fix/max-buffer-binding-size
branch
from
2fa305b to
b69a79f
Compare
Member
|
Rebased onto latest |
Contributor
Author
|
@ErichDonGubler looks good |
ErichDonGubler
force-pushed
the
fix/max-buffer-binding-size
branch
from
b69a79f to
cf76de9
Compare
1 task
github-merge-queue bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Mar 24, 2026
wgpu update for v29. I have tested on macos m1, m5, and windows. Linux testing is appreciated. - [x] before merge, naga_oil and dlss_wgpu need to be published, and the patches referencing their respective PRs removed from the workspace Cargo.toml ##### other PRs - naga_oil: bevyengine/naga_oil#134 - dlss_wgpu: bevyengine/dlss_wgpu#27 ##### Source of relevant changes - `Dx12Compiler::DynamicDxc` no longer has `max_shader_model` - gfx-rs/wgpu#8607 - `Dx12BackendOptions::force_shader_model` comes from: - gfx-rs/wgpu#8984 - Allow optional `RawDisplayHandle` in `InstanceDescriptor` - gfx-rs/wgpu#8012 - Add `GlDebugFns` option to disable OpenGL debug functions - gfx-rs/wgpu#8931 - Add a DX12 backend option to force a certain shader model - gfx-rs/wgpu#8984 - Migrate validation from maxInterStageShaderComponents to maxInterStageShaderVariables - gfx-rs/wgpu#8652 - gaps are now supported in bind group layouts - gfx-rs/wgpu#9034 - depth validation changed to option to match spec - gfx-rs/wgpu#8840 - SHADER_PRIMITIVE_INDEX is now PRIMITIVE_INDEX - gfx-rs/wgpu#9101 - Support for binding arrays of RT acceleration structures - gfx-rs/wgpu#8923 - Make HasDisplayHandle optional in WindowHandle - gfx-rs/wgpu#8782 - `QueueWriteBufferView` can no longer be dereferenced to `&mut [u8]`, so use `WriteOnly`. - gfx-rs/wgpu#9042 - ~bevy_mesh currently has an added dependency on `wgpu`, can we move `WriteOnly` to wgpu-types?~ (it is in wgpu-types now) - Change max_*_buffer_binding_size type to match WebGPU spec (u32 -> u64) - gfx-rs/wgpu#9146 - raw vulkan init `open_with_callback` takes Limits as argument now - gfx-rs/wgpu#8756 ## Known Issues There is currently one known issue with occlusion culling on macos, which we've decided to disable on macos by checking the limits we actually require. This makes it so that if wgpu releases a patch fix, bevy 0.19 users will benefit from occlusion culling re-enabling for them. <details><summary>More details</summary> On macos, the wpgu limits were changed to align with the spec and now put the early and late GPU occlusion culling `StorageBuffer` limit at 8, but we currently use 9. [Filed in wgpu repo](gfx-rs/wgpu#9287) ``` 2026-03-19T01:37:10.771117Z ERROR bevy_render::error_handler: Caught rendering error: Validation Error Caused by: In Device::create_bind_group_layout, label = 'build mesh uniforms GPU late occlusion culling bind group layout' Too many bindings of type StorageBuffers in Stage ShaderStages(COMPUTE), limit is 8, count was 9. Check the limit `max_storage_buffers_per_shader_stage` passed to `Adapter::request_device` ``` </details> solari working on wgpu 29: <img width="1282" height="752" alt="image" src="https://github.com/user-attachments/assets/4744faec-65c0-4a72-93e1-34a721fc26d8" /> --------- Co-authored-by: atlv <email@atlasdostal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Related to #8105
Description
Changes types of
max_uniform_buffer_binding_sizeandmax_storage_buffer_binding_sizetou64, following theWebGPUspec.Updates all uses accordingly.
Testing
Type change, so new tests not applicable.
MetadataEntryassertion had to be changed due to the different types. I don't understand all the implementation details of this, so please review carefully.Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format. - Triggers massive change log, skippedcargo clippy --tests. If applicable, add:--target wasm32-unknown-unknown--target x86_64-apple-darwincargo xtask testto run tests.CHANGELOG.mdentry.