ggml: add env var GGML_OP_OFFLOAD_MIN_BATCH#18535
Merged
ggerganov merged 5 commits intoggml-org:masterfrom Jan 8, 2026
Merged
Conversation
* makes the min_batch_size for triggering op offload configurable via env var, defaulting to the prior hardcoded value of 32
ggerganov
reviewed
Jan 2, 2026
Member
ggerganov
left a comment
There was a problem hiding this comment.
The env var should be read only once upon device initiali§ation and then queried from the device context.
Contributor
Author
|
Took a crack at this, let me know if you'd recommend doing anything differently. AI-assisted with searching for the relevant code in the Metal backend and with debugging compile failures.
I tested CUDA locally on a
|
4 tasks
Contributor
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
Looks good to me for SYCL backend part.
Contributor
|
The Vulkan changes are fine. |
am17an
approved these changes
Jan 6, 2026
Co-authored-by: Aman Gupta <amangupta052@gmail.com>
Contributor
|
@ggerganov merge? |
gary149
pushed a commit
to gary149/llama-agent
that referenced
this pull request
Jan 8, 2026
* ggml: add env var GGML_OP_OFFLOAD_MIN_BATCH * makes the min_batch_size for triggering op offload configurable via env var, defaulting to the prior hardcoded value of 32 * ggml: read GGML_OP_OFFLOAD_MIN_BATCH once and store to dev ctx * cann: forward declaration of device context struct * cann: move offload op check after device context declaration * cuda: fix whitespace Co-authored-by: Aman Gupta <amangupta052@gmail.com> --------- Co-authored-by: Aman Gupta <amangupta052@gmail.com>
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18530 / #17026
Makes the
min_batch_sizefor triggering op offload configurable via env var, defaulting to the prior hardcoded value of32if not specified to keep current behavior intact.This is helpful when running large MoEs with a significant size of weights stored in host buffers on CPU, causing a bottleneck when op offloading with small batches that are still larger than the default
32. The optimal value, or "break even point" here depends on characteristics of the hardware + model, and is best determined empirically (ref: #17026 (comment)).Make sure to read the contributing guidelines before submitting a PR