Skip to content

common : fix jinja warnings with clang 21#22313

Merged
angt merged 1 commit intoggml-org:masterfrom
angt:common-fix-jinja-warnings-with-clang-21
Apr 24, 2026
Merged

common : fix jinja warnings with clang 21#22313
angt merged 1 commit intoggml-org:masterfrom
angt:common-fix-jinja-warnings-with-clang-21

Conversation

@angt
Copy link
Copy Markdown
Member

@angt angt commented Apr 24, 2026

Overview

Fix jinja warnings with clang 21

Additional information

Requirements

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt angt requested a review from CISC as a code owner April 24, 2026 07:24
@angt
Copy link
Copy Markdown
Member Author

angt commented Apr 24, 2026

cc @ggerganov

Comment thread common/jinja/runtime.h
Comment on lines +204 to 206
[[noreturn]] value execute_impl(context &) override {
throw break_statement::signal();
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just silly, but fine. :P

@github-actions github-actions Bot added the jinja parser Issues related to the jinja parser label Apr 24, 2026
@ggerganov ggerganov added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Apr 24, 2026
@angt angt merged commit dc80c52 into ggml-org:master Apr 24, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jinja parser Issues related to the jinja parser merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants