Skip to content

chat: fix handling of space in reasoning markers#22353

Merged
pwilkin merged 3 commits intoggml-org:masterfrom
pwilkin:parser-fix-space
Apr 25, 2026
Merged

chat: fix handling of space in reasoning markers#22353
pwilkin merged 3 commits intoggml-org:masterfrom
pwilkin:parser-fix-space

Conversation

@pwilkin
Copy link
Copy Markdown
Member

@pwilkin pwilkin commented Apr 25, 2026

Overview

Extracted from #22162 (thanks @roj234 ), just the fix for the parser

Additional information

We're putting off the prefill changes for a further PR (prepared by @aldehir ) so I'm just taking this fix as a standalone.

Requirements

@pwilkin pwilkin requested a review from a team as a code owner April 25, 2026 12:20
@pwilkin pwilkin requested review from CISC and aldehir April 25, 2026 12:21
@aldehir
Copy link
Copy Markdown
Contributor

aldehir commented Apr 25, 2026

CI is mad again

@pwilkin
Copy link
Copy Markdown
Member Author

pwilkin commented Apr 25, 2026

Need to fix tests

@pwilkin pwilkin requested a review from ggerganov as a code owner April 25, 2026 17:04
@github-actions github-actions Bot added the testing Everything test related label Apr 25, 2026
@pwilkin
Copy link
Copy Markdown
Member Author

pwilkin commented Apr 25, 2026

Aight, fixed tests, ran server tests locally, ran a session with Qwen3.5 on OpenCode, looks good.

@pwilkin pwilkin requested a review from aldehir April 25, 2026 17:05
@aldehir
Copy link
Copy Markdown
Contributor

aldehir commented Apr 25, 2026

Just need to clean up the trailing whitespace.

tests/test-chat.cpp:
	4003: Trailing whitespace

1 errors found

@pwilkin pwilkin merged commit dcad77c into ggml-org:master Apr 25, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants